fix(github_repository_file): delete error handling and codesigning #2736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanmartos
changed the title
ivanmartos
changed the title
|
This is technically a breaking change - prior to the change this would fail forward, after the change an error is thrown - functionally the operation does not work either way but user workflows could be disrupted even still. We'll schedule this one to go out in the up coming major release. Thank you for working on this change - we'll work to get it out the door! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2735
Before the change?
github_repository_filefails silentlygithub_repository_filethen incompleteRepositoryContentFileOptionsis passed to github sdk. This means that deletion commit is not signed and in case there is a ruleset requiring signed commits, this delete commit will fail silentlyTestAccGithubRepositoryFilethey fail with duplicate repository nameAfter the change?
github_repository_fileno longer fails silently, but if there is an error, it is retrunedRepositoryContentFileOptionsis passed to sdk call toDeleteFile(same as for create and update methods). This way commits are signedTestAccGithubRepositoryFiletest execution creates new repository specific for given testPull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!